Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in README #567

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update links in README #567

merged 1 commit into from
Dec 18, 2023

Conversation

marcelbirkner
Copy link
Contributor

@marcelbirkner marcelbirkner commented Oct 24, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates links in main README due to restructuring the chart directory

@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: no labels Oct 24, 2023
@poiana poiana requested review from alacuku and bencer October 24, 2023 08:48
@poiana
Copy link
Contributor

poiana commented Oct 24, 2023

Welcome @marcelbirkner! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/S label Oct 24, 2023
@marcelbirkner
Copy link
Contributor Author

Sorry, I forgot the signoff on the first commit.

Signed-off-by: Marcel Birkner <[email protected]>

Issif
Issif previously approved these changes Oct 24, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits and signoff

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use rebase and not merge

Signed-off-by: Marcel Birkner <[email protected]>
@leogr
Copy link
Member

leogr commented Dec 18, 2023

please use rebase and not merge

Hey @cpanato

I've rebased this PR. The merge commit is now gone. PTAL and approve eventually 🙏

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@poiana poiana added the lgtm label Dec 18, 2023
@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

LGTM label has been added.

Git tree hash: 77c05dd7655dfc15532ffa191a168f2d0ea87dbf

@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, marcelbirkner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2f57edb into falcosecurity:master Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants