docs(recipes): add text/plain media handler recipe #2419
Conversation
There was a problem hiding this comment.
Thanks for this pull request, @EricGoulart @diegomirandap!
However, it seems that you have only added the Python file, and tests (that is nice 👍); you also need to write the recipe itself (place it under docs/user/recipes/), and include your file.
Moreover, it seems that you need to address merge conflicts, as you based your work and older version of our main branch.
(See other comments inline.)
examples/recipes/plain_text_main.py
Outdated
| @classmethod | ||
| @functools.lru_cache | ||
| def _get_charset(cls, content_type): | ||
| _, params = cgi.parse_header(content_type) |
There was a problem hiding this comment.
cgi has been removed from CPython 3.13+. You can use our own replacement: falcon.parse_header().
tests/test_recipes.py
Outdated
|
|
||
| assert response.status_code == 200 | ||
| assert response.content_type == 'text/plain' | ||
| assert response.text == payload |
There was a problem hiding this comment.
Newline missing at the end of file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7728 7728
Branches 1071 1071
=========================================
Hits 7728 7728 ☔ View full report in Codecov by Sentry. |
vytas7
changed the title
Summary of Changes
introduce a new recipe demonstrating a text/plain media handler implementation the recipe includes serialization and deserialization logic, with support for custom charsets.
Related Issues
Closes #2037