feat(CORS): set allow private network header

[zodecky]

Summary of Changes

Allow private networks as an option in CORS

Related Issues

#2381

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

• Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
• Added tests for changed code.
• Prefixed code comments with GitHub nick and an appropriate prefix.
• Coding style is consistent with the rest of the framework.
• Updated documentation for changed code.
  • Added docstrings for any new classes, functions, or modules.
  • Updated docstrings for any modifications to existing code.
  • Updated both WSGI and ASGI docs (where applicable).
  • Added references to new classes, functions, or modules to the relevant RST file under docs/.
  • Updated all relevant supporting documentation files under docs/.
  • A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
  • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
• Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ab2ce4c) to head (dac0d17).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7726      7726           
  Branches      1071      1071           
=========================================
  Hits          7726      7726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vytas7]

Something looks wrong... 😕
Have you changed line endings, or why does the whole file look as changed? Aha, you added middleware.py as a top-level file... Please make changes to falcon/middleware.py instead.

Moreover, before merging, we'll need to add tests covering the new code, and a Towncrier newsfragment.

[zodecky]

Ok! Thank you! I Will change that!

[zodecky]

i am adding the tests, and changed the file placement

[zodecky]

I added a test in TestCustomCorsMiddleware, but I am not sure if it was supposed to be in the TestCorsMiddleware
I put it in custom because it's an optional value and not default. Also I didnt change any of the existing tests, should I also add like
assert 'Access-Control-Allow-Private-Network'.lower() not in h in the existing tests?

[vytas7]

It seems that our tests fail with the newly released websockets 14.0, this is not caused by your changes. We'll try to address this separately.

[zodecky]

okk