Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cibw): productify the cibuildwheel workflow #2311

Merged
merged 17 commits into from
Aug 30, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Aug 29, 2024

Examples of a successful run:

I also bumped the tag to dev2 in order to be able to dispatch a new build to TestPyPI.

Closes #2310.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3e32ff7) to head (3cacc9d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7471      7471           
  Branches      1278      1278           
=========================================
  Hits          7471      7471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 marked this pull request as ready for review August 30, 2024 05:19
@vytas7 vytas7 requested review from kgriffs and CaselIT August 30, 2024 05:19
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also publish a pure python wheel for pypy and other python versions not covered?

.github/workflows/cibuildwheel.yaml Show resolved Hide resolved
@vytas7
Copy link
Member Author

vytas7 commented Aug 30, 2024

Should we also publish a pure python wheel for pypy and other python versions not covered?

This needs discussion I think, I did take this into consideration, but haven't added any NOTE yet. Let's discuss this on Gitter/Matrix.

@vytas7
Copy link
Member Author

vytas7 commented Aug 30, 2024

Should we also publish a pure python wheel for pypy and other python versions not covered?

Added to the workflow now.

@vytas7 vytas7 requested a review from CaselIT August 30, 2024 08:32
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things.

.github/workflows/cibuildwheel.yaml Outdated Show resolved Hide resolved
.github/workflows/cibuildwheel.yaml Show resolved Hide resolved
@vytas7 vytas7 requested a review from CaselIT August 30, 2024 09:44
@vytas7 vytas7 merged commit 92b4b8b into falconry:master Aug 30, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize cibuildwheel tooling
2 participants