feat: generalize validators and support jsonschema-rs
#2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port integrating other validation libraries
CaselIT
commented
Apr 4, 2024
|
The tests are missing for the new lib |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 65 +2
Lines 6931 6987 +56
Branches 1258 1266 +8
=========================================
+ Hits 6931 6987 +56 ☔ View full report in Codecov by Sentry. |
vytas7
changed the title
jsonschema-rs
|
I love this improvement, but I would like to coordinate this with an App-wide OpenAPI spec, and App-wide media validators (we would support both ways, just as middleware and hooks coexist). Unfortunately we won't be able to complete all this before the 4.0 release. Let's circle back on this for 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Extract a common interface for the validator logic, and add support for jsonschema-rs library
Related Issues
Fixes: #2224