Skip to content

Unify subscription topic handling and fix it for REST (#328)

Codecov / codecov/project succeeded Nov 29, 2023 in 0s

56.90% (+1.15%) compared to c19531d

View this Pull Request on Codecov

56.90% (+1.15%) compared to c19531d

Details

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (c19531d) 55.75% compared to head (914d77d) 56.90%.

❗ Current head 914d77d differs from pull request most recent head 3b226bb. Consider uploading reports for the commit 3b226bb to get more accurate results

Files Patch % Lines
src/core/include/SubscriptionTopic.hpp 46.55% 6 Missing and 25 partials ⚠️
src/majordomo/include/majordomo/RestBackend.hpp 26.47% 7 Missing and 18 partials ⚠️
src/client/include/Client.hpp 39.28% 3 Missing and 14 partials ⚠️
src/majordomo/include/majordomo/Worker.hpp 9.09% 2 Missing and 8 partials ⚠️
src/majordomo/include/majordomo/Broker.hpp 12.50% 0 Missing and 7 partials ⚠️
src/client/include/MockServer.hpp 25.00% 0 Missing and 3 partials ⚠️
src/client/include/RestClientNative.hpp 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   55.75%   56.90%   +1.15%     
==========================================
  Files          69       69              
  Lines        7291     7347      +56     
  Branches     2691     2722      +31     
==========================================
+ Hits         4065     4181     +116     
+ Misses       1489     1340     -149     
- Partials     1737     1826      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov