Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscription topic handling #323

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix subscription topic handling #323

merged 3 commits into from
Oct 30, 2023

Conversation

frankosterfeld
Copy link
Contributor

@frankosterfeld frankosterfeld commented Oct 20, 2023 •
edited
Loading

  • Ensure that a client subscription "/service?a=b" arrives in the worker as such, and not as "/service".
  • Ensure that clients subscriptions "/service?a&b" and "/service?b&a" are treated the same, i.e. that the params are sorted alphabetically when passed to ZMQ.

@frankosterfeld frankosterfeld force-pushed the frank/pass-subscription-params branch from 8aba5f3 to 524abd3 Compare October 20, 2023 10:16
@frankosterfeld frankosterfeld force-pushed the frank/pass-subscription-params branch from 524abd3 to bf358db Compare October 20, 2023 10:29
@frankosterfeld frankosterfeld force-pushed the frank/pass-subscription-params branch from bf358db to b4c346d Compare October 20, 2023 10:43
@frankosterfeld frankosterfeld force-pushed the frank/pass-subscription-params branch from b4c346d to f8ec0c1 Compare October 25, 2023 08:26
@wirew0rm wirew0rm force-pushed the frank/pass-subscription-params branch from 9e094bf to 9c548b6 Compare October 30, 2023 12:33
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 12:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 12:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 12:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 12:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 12:34 — with GitHub Actions Inactive
@wirew0rm
SubscriptionTopic: constrain constructor
4e54204 
Constrain the SubscriptionTopic's ctor argument to not allow recursive
calls beating other constructors in overload resolution.

Also update the sonatype github action to the current version to resolve
the java11 warning.
@wirew0rm wirew0rm force-pushed the frank/pass-subscription-params branch from e76f875 to 4e54204 Compare October 30, 2023 13:04
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:04 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:04 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:04 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:04 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:04 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:48 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:48 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:48 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:48 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:48 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage October 30, 2023 13:48 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

54.3% 54.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wirew0rm wirew0rm merged commit be867a6 into main Oct 30, 2023
8 of 11 checks passed
@wirew0rm wirew0rm deleted the frank/pass-subscription-params branch October 30, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirew0rm wirew0rm wirew0rm approved these changes

@ivan-cukic ivan-cukic Awaiting requested review from ivan-cukic

@RalphSteinhagen RalphSteinhagen Awaiting requested review from RalphSteinhagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankosterfeld @wirew0rm