Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMas-Day-3: added Rotator block fixed frequency shifter #493

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

RalphSteinhagen
Copy link
Member

On the third day of Christmas 🎄 👼 3️⃣ 🎄 , my code base gave to me...

A Rotator block i.e fixed frequency shifter

  • Introduce Rotator block that increments the phase before rotating each sample.
  • handles angle wrapping to keep accumulated_phase in [0, 2π).

for more info see here.

Some visual unit-test examples:

image

- Introduce Rotator block that increments the phase before rotating each sample.
- handles angle wrapping to keep accumulated_phase in [0, 2π).

Signed-off-by: Ralph J. Steinhagen <[email protected]>
@RalphSteinhagen RalphSteinhagen linked an issue Dec 26, 2024 that may be closed by this pull request
@RalphSteinhagen RalphSteinhagen changed the title XMas-Day-2: added Rotator block fixed frequency shifter XMas-Day-3: added Rotator block fixed frequency shifter Dec 26, 2024
Copy link
Contributor

@drslebedev drslebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR.

The new Rotator block and its unit tests look good and appear functionally correct.

There are a few minor issues worth addressing but PR can be also merged as is.

blocks/math/include/gnuradio-4.0/math/Rotator.hpp Outdated Show resolved Hide resolved
blocks/math/include/gnuradio-4.0/math/Rotator.hpp Outdated Show resolved Hide resolved
blocks/math/include/gnuradio-4.0/math/Rotator.hpp Outdated Show resolved Hide resolved
@RalphSteinhagen RalphSteinhagen merged commit dfa78d2 into main Jan 3, 2025
10 of 12 checks passed
@RalphSteinhagen RalphSteinhagen deleted the rotator_block branch January 3, 2025 09:36
@RalphSteinhagen
Copy link
Member Author

@drslebedev thanks for your feedback. I incorporated your comments and squash-merged them.

Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotator
2 participants