XMas-Day-2: Selector block: fix sign-conversion warnings & minor cleanup #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- explicitly cast sizes for std::copy_n and tag checks - use single-step wrap for negative tag index checks Signed-off-by: Ralph J. Steinhagen <[email protected]>
RalphSteinhagen
force-pushed
the
fix-selector-block-warnings
branch
from
c733b9e to
0a75ca7
Compare
|
drslebedev
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the second day of Christmas 🎄 👼 2️⃣ 🎄 , my code base gave to me...
A selector block with sign fixes galore — or at least three
This PR primarily removes GCC/Clang sign-conversion warnings by explicitly casting from std::size_t to std::ptrdiff_t where needed. Otherwise, no major new features -- just a small patch compatible with the time after a “Christmas induced food coma” and to minimise compiler warnings ...
Did I mention that I love unit tests? Thanks to @drslebedev!