cmake: use PROJECT_SOURCE_DIR instead of CMAKE_SOURCE_DIR #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use PROJECT_SOURCE_DIR instead of CMAKE_SOURCE_DIR, since when gnuradio4 is built as a dependency using FetchContent_Declare(), CMAKE_SOURCE_DIR points to the source of the application that depends on gnuradio4 instead of gnuradio4's source. Signed-off-by: Daniel Estévez <[email protected]>
|
Just seen this change is included as part of #484, so disregard this PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use PROJECT_SOURCE_DIR instead of CMAKE_SOURCE_DIR, since when gnuradio4 is built as a dependency using FetchContent_Declare(), CMAKE_SOURCE_DIR points to the source of the application that depends on gnuradio4 instead of gnuradio4's source.