Skip to content

Commit

Permalink
incorporated review comments where applicable.
Browse files Browse the repository at this point in the history
Signed-off-by: Ralph J. Steinhagen <[email protected]>
  • Loading branch information
RalphSteinhagen committed Dec 30, 2024
1 parent 5b7d71f commit a8dd7e7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions core/include/gnuradio-4.0/HistoryBuffer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class HistoryBuffer {
*/
template<std::ranges::range Range>
constexpr void push_back(const Range& range) noexcept {
push_back_bulk(range.cbegin(), range.cend());
push_back_bulk(std::ranges::begin(range), std::ranges::end(range));
}

template<std::ranges::range Range>
Expand Down Expand Up @@ -213,7 +213,7 @@ class HistoryBuffer {
*/
template<std::ranges::range Range>
constexpr void push_front(const Range& r) noexcept {
push_front(std::begin(r), std::end(r));
push_front(std::ranges::begin(r), std::ranges::end(r));
}

/**
Expand Down Expand Up @@ -277,7 +277,7 @@ class HistoryBuffer {
std::copy(newBuf.begin(), newBuf.begin() + static_cast<std::ptrdiff_t>(copyCount), newBuf.begin() + static_cast<std::ptrdiff_t>(newCapacity)); // mirror second half

// update members
_buffer = std::move(newBuf); // destroys old buffer
std::swap(_buffer, newBuf);
_capacity = newCapacity;
_size = copyCount;
_write_position = 0; // implementation choice
Expand Down

0 comments on commit a8dd7e7

Please sign in to comment.