Skip to content

Commit

Permalink
test: prevent segfault in imageverifier test
Browse files Browse the repository at this point in the history
When VeriftImage returns an error, the first return value may be set to
nil (this is the case for timeouts). When that is the case, it makes no
point trying to access its fields later in the test. Let's use
testify/require instead of testify/assert here to ensure the test halts
upon failure.

Signed-off-by: Athos Ribeiro <[email protected]>
  • Loading branch information
athos-ribeiro committed Oct 19, 2024
1 parent 7c7c3cf commit 1617fd7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/imageverifier/bindir/bindir_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func TestBinDirVerifyImage(t *testing.T) {
})

j, err := v.VerifyImage(ctx, "registry.example.com/image:abc", ocispec.Descriptor{})
assert.NoError(t, err)
require.NoError(t, err)
assert.True(t, j.OK, "expected OK, got not OK with reason: %v", j.Reason)
assert.Less(t, len(j.Reason), len(bins)*(outputLimitBytes+1024), "reason is: %v", j.Reason) // 1024 leaves margin for the formatting around the reason.
})
Expand Down

0 comments on commit 1617fd7

Please sign in to comment.