forked from GoogleCloudPlatform/cloud-run-button
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from GoogleCloudPlatform:master #10
Open
pull
wants to merge
28
commits into
fahedouch:master
Choose a base branch
from
GoogleCloudPlatform:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the SERVICE_URL environment variable passed to the Post-Create command that has as value the URL of the deployed Cloud Run service.
Co-authored-by: Ahmet Alp Balkan <[email protected]>
Introducing an optional "order" key to the env object. The sorting takes a look at if "order" field is specified or not. If not, the key is prompted last. If specified, it sorts them by the value of the "order" field. The order is still non-deterministic if env objects don't specify an "order" value. (i.e. this patch still doesn't preserve map order). Signed-off-by: Ahmet Alp Balkan <[email protected]>
* implement signaling clone status fixes #210 Signed-off-by: Ahmet Alp Balkan <[email protected]> * update local dev docs Signed-off-by: Ahmet Alp Balkan <[email protected]>
…unts (#219) * experiment: instrumentless for users without projects or billing accounts * update event id * cleanup * better handling for when the user has a billing account * error handling on coupon get
* handling for invalid trycgp url and option to create a project * better code parsing
* Add integration tests Also fix bug in #228
* Enable debugging * Lift debugging * Cleanup comments, formatting * (try) is it a caching issue? then clear it
* feat: implement artifact registry integration * WIP: update GAR code, bump golang version * go fmt * return thing * return other thing * bump integration tests go version * cleanup, add proper ux * debug confirm which filesystem we're filling * oops * update registry config * update logic, comments * use go 1.21, matching cloud shell latest * go mod tidy * add more potential cleanup options * attempt removing glibc issues * address code review * (debug) remove potentially superfluous sudo * lol * correct artifact registry identifier * note outstanding implementation * update error handling * enable artifactregistry, not containerregistry * add error handling in tryFixServiceName
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.26.0 to 0.31.0. - [Commits](golang/crypto@v0.26.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )