Updated search assertions on some search tests / throttle tests (mocks and assertions)

[jbigman]

Throttle tests

Updated api calls to use mocks in throttle tests.
Updated expected delay between calls to be at least 4000ms when throttle delay is set to 5000ms.
When using throttle with 5000ms between 3 requests, the exact delay was sometime 4000 + 6000 or 5000 + 5000.

function setTimeout documentation:

/**
 * Schedules execution of a one-time `callback` after `delay` milliseconds. The `callback` will likely not be invoked in precisely `delay` milliseconds.
 * Node.js makes no guarantees about the exact timing of when callbacks will fire, nor of their ordering. The callback will be called as close as possible to the time specified.
 * When `delay` is larger than `2147483647` or less than `1`, the `delay` will be set to `1`. Non-integer delays are truncated to an integer.
 *  * If `callback` is not a function, a [TypeError](https://nodejs.org/api/errors.html#class-typeerror) will be thrown.
 *  * @SInCE v0.0.1
 * */

[facundoolano]

this should be a dev dependency, since is it's only for tests

[facundoolano]

add some comments explaining what this does and why we need it

[facundoolano]

if I understand correctly, we're testing the throttle function generically here (outside of any integration with google play), which is good. But since we are in control, can you set the test up to work with lower waits? it's not desirable to have unit tests running for 15 seconds if we can help it.

Ideally you should update this test to work in < 1s, and remove the need for increasing this timeout

[jbigman]

The throttle test used to call external api. If we don't want to rely on the availability of this particular api we can use mocks.
The fake server intercept http calls and return specified objects if it mach the same method/url.

[jbigman]

It could be extended to play store calls, but if we mocks responses we won't be able to see play store interface changes.

[facundoolano]

I think it's better to keep it agnostic since the module is generic as well (ideally we wouldn't implement this inside this package, instead rely on another module #650 but I think at some point this was introduced because of a change in the requests library)

[jbigman]

Yes, i also searched for throttle libraries, but i found libraries that were unable to handle both interval and number of requests. I'll try the p-trottle you mentionned.

[jbigman]

p-throttle needs esm migration. i'll try it after esm migration.

[facundoolano]

left some comments