Udp-socket-thread #956
Open
Udp-socket-thread #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pretty cool work, works stable for me, congrats |
|
as you said, I can't merge this unless Window is supported too. |
|
I love the idea of using a separate threadm but can we avoid using raw socket and use Qt instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from QSocket to default linux sockets to implement the receive of packets in a separeted thread.
This solves an issue with high frequency data where plotjuggler would lose several packets while updating the plots. This issue only happens while livestreaming whithout pause, if you pause the window it receives normally all the data, but as soon as it is unpaused the issue returns.
I'm aware that this solution will lead to problems with windows implementation, but for now I dont have the time to implement with other OS compatibility.
Tested on Ubuntu 22.04..4 LTS