Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the window title to the currently loaded log file name #890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stmoon
Copy link

@stmoon stmoon commented Dec 3, 2023

When I use multiple PlotJuggler applications, I am always confused about which PlotJuggler window is associated with the log I am looking for.

To alleviate discomfort, I set the window title to the loaded log file name. It's a simple function, but I believe it's incredibly helpful.

@zdavkeos
Copy link
Contributor

zdavkeos commented Dec 9, 2023

@stmoon I pulled your branch and built it, and I do like your change. However, I think it needs to be taken a little further:

  • There is already a feature to set the window title at startup (see mainwindow.cpp), this should not be overwritten.
  • The title doesn't change when you start streaming; this would be a very nice addition.

Let me know what you think.

@facontidavide
Copy link
Owner

This will not work when loading multiple files

@Jofkos
Copy link
Contributor

Jofkos commented Apr 3, 2024

This will not work when loading multiple files

Having the title be "{first filename} and others" would still be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants