Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set bias=True for linear layer (#526) #527

Closed

Conversation

zhangtemplar
Copy link
Contributor

Summary:

  1. for output projection in text decoder, change bias=False to True. In many other places, e.g., LP head, ember's output module and LLAVA, they are using bias=True (which is default value in Linear).
  2. add configuration of using MLP instead of attention pooler for vision adapter;

Differential Revision:
D55897450

Privacy Context Container: 303860477774201

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55897450

zhangtemplar added a commit to zhangtemplar/multimodal that referenced this pull request Apr 9, 2024
Summary:


1. for output projection in text decoder, change bias=False to True. In many other places, e.g., LP head, ember's  output module and LLAVA, they are using bias=True (which is default value in Linear).
2. add configuration of using MLP instead of attention pooler for vision adapter;

Differential Revision:
D55897450

Privacy Context Container: 303860477774201
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55897450

Summary:


1. for output projection in text decoder, change bias=False to True. In many other places, e.g., LP head, ember's  output module and LLAVA, they are using bias=True (which is default value in Linear).
2. add configuration of using MLP instead of attention pooler for vision adapter;

Differential Revision:
D55897450

Privacy Context Container: 303860477774201
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55897450

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e4d288b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants