Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace torch.jit.instance with instance to assist torch.compile #522

Closed

Conversation

Bellaktris
Copy link

Summary: torch.jit.instance is mainly needed to refine Generics, but in this case instance is sufficient, instance unlike torch.jit.instance is also playing nicely with torch.compile

Differential Revision: D53797660

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53797660

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bf3779) 75.61% compared to head (65a34de) 75.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files         234      234           
  Lines       16123    16123           
=======================================
  Hits        12192    12192           
  Misses       3931     3931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ebookresearch#522)

Summary:

torch.jit.instance is mainly needed to refine Generics, but in this case instance is sufficient, instance unlike torch.jit.instance is also playing nicely with torch.compile

Differential Revision: D53797660
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53797660

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1cccc58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants