-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align to gym>0.26
interface
#99
base: main
Are you sure you want to change the base?
Conversation
Hi @epignatelli! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
||
def reset(self, wizkit_items=None): | ||
obs = self.env.reset(wizkit_items=wizkit_items) | ||
def reset(self, seed=None, options={}): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options={}
is actually dangerous here and everywhere else it repeats.
def reset(self, seed=None, options={}): | |
def reset(self, seed=None, options=None): |
would be better.
Associated issue: #98
New Feature Submissions:
Changes to Core Features:
Closing issues
Closes #98