Remove unused-variable in velox/common/base/tests/IndexedPriorityQueueTest.cpp +53 #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66719052 |
…eTest.cpp +53 (facebookincubator#11737) Summary: Pull Request resolved: facebookincubator#11737 LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`. #buildsonlynotests - Builds are sufficient - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D66719052
r-barnes
force-pushed
the
export-D66719052
branch
from
407bd6c
to
cacb5cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66719052 |
|
This pull request has been merged in bf857d9. |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Dec 4, 2024
Summary: This diff reverts facebookincubator#11737 which broke dozens of tests. Differential Revision: D66773506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LLVM-15 has a warning
-Wunused-variablewhich we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with
[[maybe_unused]].#buildsonlynotests - Builds are sufficient
Reviewed By: palmje
Differential Revision: D66719052