Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nvrtc to setup scripts. #11335

Closed
wants to merge 9 commits into from
Closed

Add nvrtc to setup scripts. #11335

wants to merge 9 commits into from

Conversation

assignUser
Copy link
Collaborator

@assignUser assignUser commented Oct 23, 2024 •
edited
Loading

#11225 requires CUDA's nvrtc library and the cuda driver stubs (on machines without a gpu) to be available.

  • Install nvrct and stubs in centos and ubuntu scripts
  • Turn GPU build back on.
  • Add missing links and remove some superflous ones
  • Turn all targets that link directly or indirectly against CUDA::cuda_driver into standalone targets as the stubbed symbols will throw a dload error on the gpu less runner. This way we keep them out of the mono library and avoid throwing errors in non-gpu tests.
  • Exclude tests that use the cuda driver stubs via label

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 7424923
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/671ae4d6a7ccca00085abb2f

@Yuhta Yuhta self-requested a review October 23, 2024 14:06
@assignUser
Copy link
Collaborator Author

@Yuhta fyi the use of cuda_driver api requires some additional links and packages to be installed, I added those.

@assignUser assignUser requested a review from kgpai October 24, 2024 00:53
@assignUser
Copy link
Collaborator Author

@Yuhta @kgpai this is ready to merge now.

@Yuhta Yuhta added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 28, 2024
@pedroerp
Copy link
Contributor

Thanks guys

@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in 33b68aa.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 33b68aa5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

@kgpai kgpai Awaiting requested review from kgpai

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@assignUser @pedroerp @facebook-github-bot @kgpai @Yuhta