Add gcc11 to Ubuntu20.04 setup and add PkgConfig install #11326
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@PHILO-HE FYI. |
|
@czentgr, the recently upgraded folly requires GCC >= 10. Otherwise, the below compile error will be reported. So we should land this pr now to avoid this error, right? |
|
@PHILO-HE Yes, basically, Ubuntu 20.04 is currently broken without these changes - the user would do all of this manually. |
|
@majetideepak @assignUser Please take a look. |
scripts/setup-ubuntu.sh
Outdated
| @@ -75,14 +91,19 @@ function install_build_prerequisites { | |||
| ninja-build \ | |||
| checkinstall \ | |||
| git \ | |||
| pkg-config \ | |||
| cmake-data \ | |||
There was a problem hiding this comment.
nit: Do we actually need cmake-data when installing via pip?
There was a problem hiding this comment.
Good point. We don't install cmake from the system. When looking for PkgConfig I though we might need more stuff. But this doesn't make sense. I'm trying it out without this package.
czentgr
force-pushed
the
cz_ubuntu_20.04_gcc11
branch
from
01ea468 to
6d8a17f
Compare
|
The pr looks good to me. Thanks! |
assignUser
added
the
ready-to-merge
|
@xiaoxmeng, if no comment, could you merge this pr? I just found this pr is also required for ubuntu 22.04 to fix missing pkg-config. |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@czentgr Would you rebase to allow merging? |
Modernize the compiler used on Ubuntu 20.04. Once Velox moves to using the C++20 standard the system gcc9 compiler cannot be used anymore. In addition, recent upgrades added the usage of PkgConfig which was not installed into the system and is not by default pre-installed into ubuntu 20.04.
czentgr
force-pushed
the
cz_ubuntu_20.04_gcc11
branch
from
6d8a17f to
9de06d2
Compare
|
@mbasmanova I rebased. Please take another look. |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in bfc199f. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Modernize the compiler used on Ubuntu 20.04. Once Velox moves to using the C++20 standard the system gcc9 compiler cannot be used anymore.
In addition, recent upgrades added the usage of PkgConfig which was not installed into the system and is not by default pre-installed into ubuntu 20.04.
Resolves: #10953