Skip to content

Commit

Permalink
Fix fast_float installation problems (#11056)
Browse files Browse the repository at this point in the history
Summary:
#11018 added install_fast_float, but didn't specify the version by default. The setup failed to download the package with the "tar: Error opening archive: Unrecognized archive format" error. Also the fast_float.cmake introduced by this PR had the wrong VELOX_FAST_FLOAT_SOURCE_URL. It is missing "refs/tags/".

This PR fixes these two problems.

Fixes #11055

Pull Request resolved: #11056

Reviewed By: DanielHunte

Differential Revision: D63344271

Pulled By: Yuhta

fbshipit-source-id: 6887b0dce4e5bc38f56949275e14d6135dc07c0b
  • Loading branch information
yingsu00 authored and facebook-github-bot committed Sep 25, 2024
1 parent a59538c commit 0dd3a5d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CMake/resolve_dependency_modules/fast_float.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ set(VELOX_FAST_FLOAT_VERSION 6.1.6)
set(VELOX_FAST_FLOAT_BUILD_SHA256_CHECKSUM
4458aae4b0eb55717968edda42987cabf5f7fc737aee8fede87a70035dba9ab0)
set(VELOX_FAST_FLOAT_SOURCE_URL
"https://github.com/fastfloat/fast_float/archive/v${VELOX_FAST_FLOAT_VERSION}.tar.gz"
"https://github.com/fastfloat/fast_float/archive/refs/tags/v${VELOX_FAST_FLOAT_VERSION}.tar.gz"
)

resolve_dependency_url(FAST_FLOAT)
Expand Down
1 change: 1 addition & 0 deletions scripts/setup-macos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ MACOS_VELOX_DEPS="bison flex gflags glog googletest icu4c libevent libsodium lz4
MACOS_BUILD_DEPS="ninja cmake"
FB_OS_VERSION="v2024.09.16.00"
FMT_VERSION="10.1.1"
FAST_FLOAT_VERSION="v6.1.6"

function update_brew {
DEFAULT_BREW_PATH=/usr/local/bin/brew
Expand Down

0 comments on commit 0dd3a5d

Please sign in to comment.