Add callback functionality to Options/Context to capture visits to getLocalDecodedVector #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60241883 |
kunalkataria
pushed a commit
that referenced
this pull request
Oct 10, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Oct 10, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Oct 10, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
force-pushed
the
export-D60241883
branch
from
0681875 to
dd542cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60241883 |
kunalkataria
pushed a commit
that referenced
this pull request
Oct 10, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Oct 18, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Oct 18, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
force-pushed
the
export-D60241883
branch
from
dd542cd to
b5d040c
Compare
kunalkataria
pushed a commit
that referenced
this pull request
Oct 18, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
|
This pull request was exported from Phabricator. Differential Revision: D60241883 |
kunalkataria
pushed a commit
that referenced
this pull request
Oct 30, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Oct 30, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Oct 30, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
force-pushed
the
export-D60241883
branch
from
b5d040c to
a254e78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60241883 |
kunalkataria
pushed a commit
that referenced
this pull request
Oct 30, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Nov 4, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Nov 4, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
force-pushed
the
export-D60241883
branch
from
a254e78 to
3e36d1e
Compare
kunalkataria
pushed a commit
that referenced
this pull request
Nov 4, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Nov 4, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
|
This pull request was exported from Phabricator. Differential Revision: D60241883 |
added 2 commits
November 6, 2024 11:35
Summary: Allows for already encoded dictionaries to passthrough the writer as opposed to being decoded + deduped again. Specifically, we want to allow for a "passthrough" without decoding when the schema indicates that we are ingesting an ArrayVector, but the array we find is a dictionaryVector with ArrayVector values. When this is the case, we will check to see if the dictionary is a valid run-length encoding (meaning, it likely has been deduped by upstream). The way in which the vector is written to storage does not change, we will still write the offsets and the ArrayVector elements. A caveat is that right now, `isDictionaryValidRunLengthEncoded` function doesn't actually verify that there is a duplicate. It's possible that a scenario exists in which a DictionaryVector was passed to the ArrayVector field writer, but the DictionaryVector has not been deduped, but its offsets still technically fulfill a run-length encoding (each offset is greater than or equal to the offset at index - 1). Reviewed By: helfman Differential Revision: D59863671
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
force-pushed
the
export-D60241883
branch
from
3e36d1e to
d50b7a8
Compare
kunalkataria
pushed a commit
that referenced
this pull request
Nov 6, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
|
This pull request was exported from Phabricator. Differential Revision: D60241883 |
kunalkataria
pushed a commit
that referenced
this pull request
Nov 6, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
kunalkataria
pushed a commit
that referenced
this pull request
Nov 6, 2024
…tLocalDecodedVector (#87) Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
|
This pull request has been merged in 3ab4c73. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code.
I did verify that the callback is being called through some tests that I know do use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now
This decode visit functionality will be used in the flatmap passthrough functionality as well
Reviewed By: helfman
Differential Revision: D60241883