-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Capture KeepAlive instead of Executor in WriterOptions (#115)
Summary: folly::Executor::KeepAlive<> is the recommended way of holding references to Executors, as they ensure the executor is kept alive until the KeepAlive object is destroyed. Because of this, some folly APIs can only return KeepAlive (and not shared_ptr), such as Global pools. These APIs cannot use WriterOption is it takes a shared_ptr Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66741079
- Loading branch information
1 parent
2fa1587
commit 8f69f60
Showing
2 changed files
with
30 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters