forked from ChromeDevTools/devtools-frontend
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedder script + local serve script #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiz88
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recapping in-person discussion:
- The Python script is redundant - we should instead develop with a local checkout of
@react-native/dev-middleware
(fbsource) and have it serve the devtools-frontend checkout. - Adding knowledge of the
/debugger-frontend/
pathname to this repo is an antipattern. This repo should work just fine if served at whatever base URL. - We should not change the
Content-Security-Policy
for the sake of a testing script. - The README changes can mostly be reverted as a result of the above.
- We should also rename
static/embedderScript.js
to something likeembedder-static/main.js
.
hoxyq
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Consider also adding async
or defer
attributes.
2 questions:
- Should it be strictly loaded before the entrypoint?
- Can user see 404 error somewhere in the logs / UI?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
embedderScript.js
to entry pointTest plan
Test page load and the static files load in browser.
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.