Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add .idea to .gitignore #5

Merged
merged 1 commit into from
Mar 4, 2024
Merged

chore: add .idea to .gitignore #5

merged 1 commit into from
Mar 4, 2024

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Mar 4, 2024

Summary

I am using WebStorn for public-only projects, this IDE creates an auxilliary .idea folder to store some information about the project, same as .vscode for VSCode.

Test plan

Running git status doesn't list .idea folder.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

EdmondChuiHW
EdmondChuiHW approved these changes Mar 4, 2024
View reviewed changes
Copy link

@EdmondChuiHW EdmondChuiHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@motiz88 motiz88 merged commit 0ae73bc into facebookexperimental:main Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdmondChuiHW EdmondChuiHW EdmondChuiHW approved these changes

@motiz88 motiz88 Awaiting requested review from motiz88

@huntie huntie Awaiting requested review from huntie

@robhogan robhogan Awaiting requested review from robhogan

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoxyq @EdmondChuiHW @motiz88 @facebook-github-bot