rm interface from RNPerfMetrics #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
Merged
huntie
requested changes
Mar 22, 2024
front_end/core/host/RNPerfMetrics.ts
Outdated
| } | ||
| return instance; | ||
| } | ||
|
|
||
| class RNPerfMetricsImpl implements RNPerfMetrics { | ||
| type UnsunscribeFn = () => void; |
There was a problem hiding this comment.
misspelling. Also can this be inlined, since it's not exported?
There was a problem hiding this comment.
Oof, fixed typo later in the stack but missed this one.
This is still exported transitively via RNPerfMetrics. I couldn't find a way to type-name the returned function inline at addListener(…).
Can put it in a comment instead if you mean the while type alias should be removed. I think it's good to document the intent somewhere. useEffect names their clean up function as Destructor, for example.
EdmondChuiHW
force-pushed
the
simplify-type
branch
from
8f8f523 to
635a2bb
Compare
motiz88
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unnecessary interface. Base PR for stack #27 and #28
Test plan
npm run buildUpstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.