Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add global typings to path" #20

Closed
wants to merge 1 commit into from
Closed

Conversation

motiz88
Copy link

@motiz88 motiz88 commented Mar 12, 2024

Reverts #18 - needs to be resubmitted with a clear commit title (for ease of future rebasing)

This reverts commit 2394a3c.
Copy link

@EdmondChuiHW EdmondChuiHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! Thought the squash-and-merge option would take the PR title. Will make sure to double-check that in the future.

Adding it back in #21 with proper message

@EdmondChuiHW
Copy link

Merged in #21

@EdmondChuiHW EdmondChuiHW deleted the revert-18-meta-license branch March 14, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants