feat: add ReactDevToolsBindingsModel #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Mar 11, 2024
Summary: Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Differential Revision: D54770207
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Mar 11, 2024
Summary: Pull Request resolved: facebook#43418 Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Differential Revision: D54770207
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Mar 11, 2024
Summary: Pull Request resolved: facebook#43418 Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Differential Revision: D54770207
hoxyq
commented
Mar 12, 2024
hoxyq
force-pushed
the
react-devtools/introduce-third-party-bindings-model
branch
2 times, most recently
from
8c63f3e to
c23f4cb
Compare
2 tasks
EdmondChuiHW
approved these changes
Mar 12, 2024
huntie
reviewed
Mar 13, 2024
hoxyq
force-pushed
the
react-devtools/introduce-third-party-bindings-model
branch
from
c23f4cb to
08f13c9
Compare
hoxyq
changed the title
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: facebook#43418 Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Differential Revision: D54770207
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: facebook#43418 Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Reviewed By: motiz88 Differential Revision: D54770207
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Apr 11, 2024
…book#43418) Summary: Pull Request resolved: facebook#43418 Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Reviewed By: motiz88 Differential Revision: D54770207
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #43418 Changelog: [Internal] This diff adds a script, which will be later imported from `InitializeCore` to setup a required global for communication between React Native runtime (RDT Backend in it) and Chrome DevTools Frontend (RDT Frontend in it). See README for the architecture overview and how bidirectional communication is established. Corresponding PR in Chrome DevTools frontend - facebookexperimental/rn-chrome-devtools-frontend#15 Reviewed By: motiz88 Differential Revision: D54770207 fbshipit-source-id: 0f0f04a338b5c7eab817c843a99b07cca95e57fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
FuseboxBindingsModel, which will establish the bidirectional communication between Chrome DevTools Frontend and React Native JS Runtime. It will:Runtime.addBindingrequest, the name of which will be parsed from RN JS Runtime viaRuntime.evaluateinvocation prior to it.ReactDevToolsModelin a future) for sending JSON-serializable messages to React Native JS runtime.Corresponding PR for RN - facebook/react-native#43418, see README and diagrams for architecture overview.
Test plan
Locally modified
rn_inspectorto import the model (so it would start),the
__FUSEBOX_REACT_DEVTOOLS_DISPATCHER__binding is created once Chrome DevTools Frontend is opened.Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.