Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync fork with chromium/6613 #144

Merged
merged 1,624 commits into from
Dec 18, 2024
Merged

Sync fork with chromium/6613 #144

merged 1,624 commits into from
Dec 18, 2024

Conversation

huntie
Copy link

@huntie huntie commented Dec 18, 2024 •
edited
Loading

Summary

Syncs the rn-chrome-devtools-frontend fork with the upstream chromium/6613 branch (most recent stable from https://chromiumdash.appspot.com/branches).

There were a total of ~40 conflicts, resolved as below:

File conflicts

  • All .png files — Use upstream
  • front_end/core/host/UserMetrics.ts — Use upstream
  • front_end/core/root/Runtime.ts — Merge changes
    • New experiment keys.
  • front_end/global_typings/global_defs.d.ts — Merge changes
  • front_end/panels/js_timeline/js_timeline-meta.ts — Use upstream
    • References to “Profiler” removed.
  • front_end/panels/timeline/timeline-meta.ts — Merge changes
  • front_end/panels/profiler/ProfilesPanel.ts — Use upstream
    • ⚠️ Significant: JSProfilerPanel is removed.
  • front_end/panels/timeline/track_appenders/AppenderUtils.test.ts — Use upstream
    • backgroundColor tweak.
  • front_end/testing/EnvironmentHelpers.ts — Merge changes
    • New registered experiment keys.
  • front_end/third_party/additional_readme_paths.json — Merge changes
  • front_end/ui/legacy/ActionRegistration.ts — Merge changes (trivial)
  • front_end/ui/legacy/remoteDebuggingTerminatedScreen.css — Merge changes (trivial)
  • front_end/ui/legacy/theme_support/ThemeSupport.ts — Merge changes
    • Modified by us in 141c8c9 to force "baseline-grayscale" theme (change preserved).
  • front_end/ui/legacy/themeColors.css — Use upstream

Other necessary changes

  • Revert https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5714669
    • Restores 'unsafe-eval' in the Content Security Policy (necessary for React DevTools panels).
  • Drop our RN-specific JS_PROFILER_TEMP_ENABLE experiment.
  • Remove loading js_profiler-meta.js in both React Native entry points.
  • Switch npm script for "Run unit tests" GitHub Actions step. This now runs the front_end test suite.
  • Remove submodule extensions/cxx_debugging/third_party/llvm/src.
    • Ran gclient sync -D.
    WARNING: 'rn-chrome-devtools-frontend/extensions/cxx_debugging/third_party/llvm/src' is no longer part of this client.
It is recommended that you manually remove it or use 'gclient sync -D' next time.
  • front_end/panels/console/ErrorStackParser.test.ts

Test plan

Smoke test on all features for rn_fusebox.html

✅ Console: https://pxl.cl/69CWn
✅ Sources: https://pxl.cl/69CWP
⚠️ Performance: https://pxl.cl/69D12

  • Reports data
  • Causes disconnection and crash — @hoxyq I think we're happy to accept the repo sync and fix forward for this WIP feature?

✅ Memory

✅ React Components: https://pxl.cl/69Gfw
✅ React Profiler: https://pxl.cl/69Gk2

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

OrKoN and others added 30 commits July 9, 2024 09:14
@OrKoN
Consider an entire response as an answer
839c16e 
Fixed: 351973653
Change-Id: Ia8621d9acc19972f4b15226c765f8fd8250b09d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687117
Auto-Submit: Alex Rudenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
@Lightning00Blade
[Freestyler] Fix stop button style
1b096c1 
Also fixes some styling on the input container

Bug: 351969243
Change-Id: I846b0db4fc3d99f9c4e51fcabbf4bf860d5a84c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687118
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
@and-oli
[RPP extensibility] Simplify DevTools object
2451682 
Did the following changes to the type of the devtools object defined to be inside the `detail` param of performance.measure / mark for passing perf panel extension data:

1. Removed nested metadata field to avoid deep nested objects.
2. Moved the dataType  field to the top level of the devtools object and made it optional  defaulting to ”track-entry” when undefined.


These changes are documented in the changelog at the bottom of the public entry point of the extensibility feature:
https://bit.ly/rpp-e11y

Also updated the ExtensionTraceDataHandler to use hardcoded events instead of a trace fixture, to allow us to test new features / changes without having to update the existing fixture.

Bug: 347681939
Change-Id: Ia2ec0a44dde3a68b116db31dd24d29343d355a6b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683046
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>
@jackfranklin
Enable DoNotSubmit checks in PRESUBMIT
6bc1cbd 
This check will fail if the CL contains the phrase
`DO<SPACE>NOT<SPACE>SUBMIT` in any of the files.

Bug: none
Change-Id: I3055082c90a40de5f5b97208edc9ea895f2f25ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688031
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
@and-oli
[RPP ext] Check more strictly if extension data is valid
9ab4ac0 
Before extracting the `devtools` object in the details of a user timing
and using it as extension data, ensure that it contains the expected
fields needed for the current extensibility features (which differ
on extension markers and extension track entries).

Also add more unit tests to cover this behaviour.

Bug: 347681939
Change-Id: Ie89d7e8c95e769089f8e51d6259c83460b44ce8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687910
Commit-Queue: Nancy Li <[email protected]>
Auto-Submit: Andres Olivares <[email protected]>
Reviewed-by: Nancy Li <[email protected]>
Update DevTools DEPS (trusted)
9177b42 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/56e49c7..b6789a6

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/e73bcd1..1bdde81

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1387a8c..01e29c8

Roll created at https://cr-buildbucket.appspot.com/build/8742891019871123393

Bug: none
Change-Id: I442e06cd3ae608a1d13aad9e785b3251519c58aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687954
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
@danilsomsikov
[test] Fix a couple of order-dependent tests
d25803b 
Bug: none
Change-Id: I48a9991dc3bdbc18499c114f639adf997c54bdcb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688030
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
@jackfranklin
Trace engine: clear websocketData between traces
d4d31f7 
Bug: none
Change-Id: I52ca7c49d3bbd99266808815668c4afd40f5fad2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687956
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Andres Olivares <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Update Chrome (for Testing) PIN
b989a1e 
Chromium pin updated to 128.0.6585.0

Roll created at https://cr-buildbucket.appspot.com/build/8742891019871123393

Bug: none
Change-Id: I158a975113eb0a6b7d4a7b243ccc8b3e58c46c72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688037
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
@jackfranklin
Always initialise traceBounds in test
f525f82 
This tidies up some of the console noise when running the unit tests.

Historically we supported passing `false` here, but there's no need to
actually not-init the bounds manager, and the test modified here didn't
do it for any particular reason, so we might as well always do it, which
is good because it more closely aligns the tests with what happens in
reality when people use the perf panel.

Bug: none
Change-Id: Ieee39770c54c476f05628be4feb731d5f363b694
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687957
Reviewed-by: Philip Pfaffe <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
@Lightning00Blade
Extract AIDA client events to AidaClient
96b97a5 
Bug: none
Change-Id: Iad28a8d8d93d5a24c54179674e5006379285eec3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687951
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
[testing] fix interaction tests coverage
715da07 
Bug: 333423685
Change-Id: Idfc1d058e4041afe4e53fc2aa63f877b9bbe27ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688550
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Auto-Submit: Liviu Rau <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
@pfaffe
[testing] fix unittest coverage
597da92 
[email protected]

Bug: 333423685
Change-Id: Ifec5deba457ec5dbe7d3241f493bcf1b668559d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687590
Auto-Submit: Philip Pfaffe <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
Reviewed-by: Liviu Rau <[email protected]>
@pfaffe
[testing] Glob test inputs
a25e31f 
Bug: 333423685
Change-Id: I84d992065c16cc6d83cce7ec57b0283f191d7028
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688553
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
@jackfranklin
RPP: cache SyntheticEventsManager on rawEvents array to fix tests
efce5da 
We have had some tests on CI that fail when run as part of the overall
DevTools suite, but pass in isolation.

One of the reasons this happens is because of how the
SyntheticEventsManager is initialised. In tests, because we cache and
don't re-run model.parse() on the same trace, we end up not having the
right active SyntheticEventsManager for a given trace. The test will
then pass if run in isolation because when it is the only test running
it has the correct data setup.

To fix this I modified the SyntheticEventsManager; now it caches
instances based on the rawEvents() array, and tracks the active one. We
did support fetching by an index, but the API didn't actually ever
return the user what the index for a given trace was, so this was
useless, and we only ever care about the active one anyway.

Bug: none
Change-Id: Ie709b8bff370c395e3eeed2029fddd5086a3b2b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687953
Reviewed-by: Alina Varkki <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
@AlinaVarkki
[RPP] Update the Entry Label Annotation in the ModificationsManager w…
f2a084e 
…hen the label changes

Update the state of the ModificationsManager annotation which, in turn,  updates the label in the sidebar as the label is edited.

Bug: 349530077
Change-Id: Iadcb1768e5673a3840348a8b861c1695943aa08e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687112
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Alina Varkki <[email protected]>
@pfaffe
[testing] Delete obsolete runners
9d80aef 
Fixed: 333423685
Change-Id: I5eb0ff36ee81fad3c50ba96b3a79d1f7296df5d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5563425
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
@jackfranklin
RPP: fix sidebar being hidden behind experiment
05e561d 
A previous CL accidentally made it so the sidebar was enabled regardless
of the experiment. This CL fixes this.

Bug: none
Change-Id: I2f568a8c9b5b372bf83881d4b0cb46ae12067674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688775
Commit-Queue: Adam Raine <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Adam Raine <[email protected]>
Add OWNERS file to models/trace
0d310b0 
Bug: None
Change-Id: I0ec27339498fe15e2aaa4dcf3e82ad89c0a2e7c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5690052
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
@danilsomsikov
[emulation] Don't change zoom if auto-adjust is off
536b854 
Bug: 339258747
Change-Id: I16f1fbbf41ea38b425a1e271bf41598b5060c467
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5689030
Reviewed-by: Changhao Han <[email protected]>
Commit-Queue: Changhao Han <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Use LanternError for errors thrown in Lantern module
d843757 
Bug: 313905799
Change-Id: I5233a10331308c1da3c217d07817333f19de7dae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5690694
Commit-Queue: Connor Clark <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Update DevTools DEPS (trusted)
c2ab99c 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/b6789a6..1714b56

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/01e29c8..93d8c01

Roll created at https://cr-buildbucket.appspot.com/build/8742834398100187137

Bug: none
Change-Id: Ib9b49a555e460f537bcc8804b2133f255050c156
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688779
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
@szuend
[common] Add one more Throttler unit test to document behavior
15451d5 
Adds a unit test that simulates scheduling a process while another
process is still in-flight.

[email protected]

Bug: None
Change-Id: I2dc3b9e909496cb5ff2be74d77bc97c14b33f5d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687952
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
@a4sriniv
Roll browser-protocol manually
6537274 
Adds a TODO in PreloadingString to add a message for newly added
failure reason.

Bug: 40287334, 350870118
Change-Id: I64a70d1b0162c206fe19b45437f3a3d8d7b90d43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688776
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
@pfaffe
[testing] Make test documentation simpler
96992fe 
Drive-by: Reorder tests when running the full set to run unittests first

Bug: 333423685
Change-Id: I7ac75c7a446fa543d3063a5ac2989fe1f15381b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688551
Commit-Queue: Simon Zünd <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
@Lightning00Blade
Move Rating enum to AidaClient
c0e387e 
Bug: none
Change-Id: I1fbeaf7203949863b84f0d7e7f7be8484286ef6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688774
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
@a4sriniv
Update BFCacheStrings
9115463 
Removes "Portals" (the portals feature has been deprecated and removed),
and changes the message for "HaveInnerContents", which now only gets
reported for pages using guest views.

Bug: 40287334
Change-Id: I769e2e8d58f9ad8d6adf338e60edc040192d72ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5677286
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
@danilsomsikov
[test] Helper to check context menus
f701898 
Bug: 348084788
Change-Id: Ibc5ab78136bbbfea59ea0340f1ae70be893f4c27
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683045
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
@WillHernandez
A plain text search should be performed when regex option is toggled …
ad57f13 
…off.

1. Search option should NOT perform a regex search when regex option is toggled off.
2. Regex searches are NOT being performed on queries that are already surrounded by forward slashes.

Problem with code:
Checks and edits during our const Query creation are too broad.

1. Queries were being surrounded by forward slashes even when they were already included in the query, eg below.
query = /example/ would then become //example//
2. In the try/catch where a new regex is created, regex.text('/example/') would create a regex for our query which is expected BUT should only occur when our Regex search option is enabled.

Fix:
Added additional checks during the creation of a new Regex.

1. First confirm this.isRegex is true && our query is NOT already surrounded by forward slashes before adding any.
2. Added an additional this.isRegex check on all new Regex creations.

[email protected]

Fixed: 349428386
Change-Id: If4a985c7cec3098f6a5358c9091db8b2cfe6890c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683367
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
@hashseed
Fix uncaught exception in the command menu
3ae980d 
When no item is selected, FilteredListWidget.onEnter should not
call Provider.selectItem with an invalid item index.

Also add some test cases.

Fixed:351766225
Change-Id: I441199921c78492dbdeeb3f37e9019b8e2b7ff9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5687116
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
devtools-ci-autoroll-builder and others added 13 commits July 22, 2024 12:49
Update Chrome (for Testing) PIN
21ac460 
Chromium pin updated to 128.0.6611.0

Roll created at https://cr-buildbucket.appspot.com/build/8741713257219513569

Bug: none
Change-Id: I89e1fc900f712e73f848515ba66366dd27607eed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5726904
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
@ktran
[GM3Restyling] Update icon and color for security panel
d1cd165 
Icons should never be gray (except of if disabled). Replacing
the indeterminate icon by the info icon.

Before: https://i.imgur.com/9VwGY0V.png
After: https://i.imgur.com/lbwEzyx.png
Bug: 319384095
Change-Id: I3a777d970ac5dc1e7c28c91ac0fe35964f6c26ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5718150
Commit-Queue: Kateryna Prokopenko <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
@jackfranklin
[RPP] Fix toggling and overlays for sidebar insights
26ee92b 
This sets up a system for knowing what insights are being toggled to
help with expanding & overlay logic.
Insights have their own name, and these
are toggled by the single-navigation-component accordingly.
These are controlled by dispatched events that pass in the
insight+navigationId info so that the correct overlay is displayed.

Bug:344550388
Also-By: [email protected]
Change-Id: I3734d3a908a96d3b30f0f598f000821e1a950bda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5715119
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Andres Olivares <[email protected]>
@ktran
Change Network Panel icon color in header overrides
207787b 
Icon colors should by default be black. Removing the
specific icon colors will default to black (--icon-default).

Fixed: 339805299
Change-Id: I837eb43d2102e3d79a87addc81575418ce01065c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5707449
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
@Lightning00Blade
Always use Rating enum
26a5add 
Improve types

Bug: none
Change-Id: Ie6111d6c9c1d8d1eac09957dd0ef714e611ba1b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729336
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
@hashseed
Change sort order of timer event break points
b4487a7 
Fixed:351408641
Change-Id: I92ec41e65ab6804bf59b5050e5284cdc9a775a41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725915
Commit-Queue: Eric Leese <[email protected]>
Auto-Submit: Yang Guo <[email protected]>
Reviewed-by: Eric Leese <[email protected]>
@szuend
[cleanup] Use a Map of Sets for extraPropertyValues
c10915f 
This allows us also to use the new Set.prototype.union. Once we have
migrated all call-sites of Platform.SetUtilities.addAll, we can remove
SetUtilities wholesale.

[email protected]

Bug: None
Change-Id: I13f8f1af0f1a46eb2a134538c1835945f15f6e47
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729973
Commit-Queue: Philip Pfaffe <[email protected]>
Auto-Submit: Simon Zünd <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
@szuend
[cleanup] Remove platform/SetUtilities.ts
48f2dfc 
We can replace the last use-sites of 'addAll' with either union or
inline it.

[email protected]

Bug: None
Change-Id: Ifc61bc4e91b21d88cb96a672941ad6ff5ef3e029
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729974
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
[GM3Restyling] Center checkbox focus ring
25d2815 
Bug: 353397958
Change-Id: I8fecc42894e0e267e913723248b43965b23cc6bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5741481
Reviewed-by: Changhao Han <[email protected]>
Commit-Queue: Changhao Han <[email protected]>
Auto-Submit: Kateryna Prokopenko <[email protected]>
(cherry picked from commit 1a1f6cf)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5745068
Reviewed-by: Kim-Anh Tran <[email protected]>
[GM3Restyling] Make small chechboxes state layers smaller
1ff27e6 
Bug: 325441956
Change-Id: Ibf7ea2fe0bf42d673701b38d9905c4c624c62339
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5741303
Commit-Queue: Changhao Han <[email protected]>
Auto-Submit: Kateryna Prokopenko <[email protected]>
Reviewed-by: Changhao Han <[email protected]>
(cherry picked from commit 537b4d3)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5746953
Reviewed-by: Kim-Anh Tran <[email protected]>
@szuend
[scopes] Fix text cache
d52e9cd 
With the 'ContentData' work we broke the text cache in NamesResolver
(introduced here https://crrev.com/c/3934889). With the 'ContentData'
work 'requestContent' would return a fresh instance of DeferredContent
on every invocation, making the cache basically useless.

This CL fixes this by caching the ContentData instead.

Bug: 356533383
Change-Id: I2fe1d23c8253dc4fa8732d87abe10fea69741d72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5752667
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
(cherry picked from commit 82b0440)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5756488
Bot-Commit: Rubber Stamper <[email protected]>
@danilsomsikov
[ve] Fix soft menu keyboard logging
660c57a 
Bug: 40276793
Change-Id: I72d2f6ce28818d0a1ff7d158607d9b74d89afef3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5757539
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
(cherry picked from commit 4275917)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5760310
@and-oli
[RPP] Sort markers before appending
47f04a5 
Markers (LCP, FCP, etc.) can come from different sources
(ExtensionDataHandler & PageLoadMetricsHandler). The
FlameChart::drawMarkers implementation assumes these markers are
appended in order so that they can be drawn correctly [1]. So, before
we append the concatenation of markers from both sources we need to
sort them.

This fixes a bug I noticed with extension markers being drawn on an
incorrect x position. [2]

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/legacy/components/perf_ui/FlameChart.ts;l=2635;drc=d9e4f0e53f58da1f8d8d84fa0d2e661226dd2d73
[2] https://screenshot.googleplex.com/5LiDg9Uv7LA8sSg

Fixed: 357056787
Change-Id: Ie60ad9dd92d7269f0fb5fda80af1114105160f8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5757144
Auto-Submit: Andres Olivares <[email protected]>
Reviewed-by: Nancy Li <[email protected]>
Commit-Queue: Nancy Li <[email protected]>
(cherry picked from commit 30ec2e9)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5756511
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
@huntie huntie changed the title Repo sync Sync fork with chromium/6613 Dec 18, 2024
@huntie huntie requested a review from hoxyq December 18, 2024 11:28
@hoxyq
Copy link

hoxyq commented Dec 18, 2024 •
edited
Loading

Didn't notice any issues with Performance panel, but RDT panels are just blank for me:
Screenshot 2024-12-18 at 14 44 38

UPDATE: no longer reproducible after rebasing on a latest version of this branch

@huntie huntie force-pushed the repo-sync branch 3 times, most recently from c466f1c to bba0bab Compare December 18, 2024 15:33
@huntie huntie marked this pull request as ready for review December 18, 2024 15:40
@huntie huntie merged commit 7727db8 into facebookexperimental:main Dec 18, 2024
3 checks passed
@huntie huntie deleted the repo-sync branch December 18, 2024 18:01
huntie added a commit to huntie/react-native that referenced this pull request Dec 18, 2024
@huntie @facebook-github-bot
Update debugger-frontend from 486803f...7727db8
2fd8d68 
Summary:
NOTE: This update is significant, as it includes the frontend repo sync with `chromium/6613` (facebookexperimental/rn-chrome-devtools-frontend#144).

Changelog: [Internal] - Update `react-native/debugger-frontend` from 486803f...7727db8

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebookexperimental/rn-chrome-devtools-frontend@486803f...7727db8).

Differential Revision: D67402065
@huntie huntie mentioned this pull request Dec 18, 2024
Open
huntie added a commit to huntie/react-native that referenced this pull request Dec 18, 2024
@huntie @facebook-github-bot
Update debugger-frontend from 486803f...7727db8 (facebook#48328)
83e733b 
Summary:
Pull Request resolved: facebook#48328

NOTE: This update is significant, as it includes the frontend repo sync with `chromium/6613` (facebookexperimental/rn-chrome-devtools-frontend#144).

Changelog: [Internal] - Update `react-native/debugger-frontend` from 486803f...7727db8

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebookexperimental/rn-chrome-devtools-frontend@486803f...7727db8).

Differential Revision: D67402065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq hoxyq approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.