Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial feature/UI customisations for profiling builds #138

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

huntie
Copy link

@huntie huntie commented Nov 26, 2024

Summary

Initial feature and UI customisations triggered when connected to a React Native profiling build (under development). Depends on facebook/react-native#47966.

Changes:

  • Adds FuseboxProfilingBuildObserver, which dynamically configures available DevTools features when a profiling build is identified.
  • Statically disables sub-features of the Performance panel (including CPU throttling, Settings pane).

Notes:

  • Includes a first run experience as shown, necessary when switching experiment settings at runtime. On subsequent launches, the Performance panel is permanently enabled (dev and profiling builds).
image image

Test plan

[Meta internal] See D66501770.

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@huntie huntie merged commit 7e54784 into facebookexperimental:main Dec 2, 2024
3 checks passed
@huntie huntie deleted the profiling-mode branch December 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants