Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore skip-stack-frames-pattern setting with empty default #137

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Restore skip-stack-frames-pattern setting with empty default #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

<!-- Explain how you've tested your change here -->

- [ ] This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

# Upstreaming plan

<!-- Pick one: -->
Expand Down
7 changes: 7 additions & 0 deletions front_end/core/sdk/sdk-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,13 @@ const UIStrings = {
const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);

Common.Settings.registerSettingExtension({
storageType: Common.Settings.SettingStorageType.Synced,
settingName: 'skip-stack-frames-pattern',
settingType: Common.Settings.SettingType.REGEX,
defaultValue: '',
});

Common.Settings.registerSettingExtension({
storageType: Common.Settings.SettingStorageType.Synced,
settingName: 'skip-content-scripts',
Expand Down
Loading