Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only prompt preserve-log settings for Fusebox targets #128

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Only prompt preserve-log settings for Fusebox targets #128

merged 1 commit into from
Oct 16, 2024

Conversation

EdmondChuiHW
Copy link

@EdmondChuiHW EdmondChuiHW commented Oct 15, 2024 •
edited
Loading

Summary

Only show this message for Fusebox targets. Follow-up on #125

Test plan

npm run unittest

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW force-pushed the rec-fusebox-targets-only branch from 4161fa2 to 70fb6fc Compare October 15, 2024 18:24
@EdmondChuiHW EdmondChuiHW force-pushed the rec-fusebox-targets-only branch from 70fb6fc to 3656d6f Compare October 16, 2024 00:42
@EdmondChuiHW EdmondChuiHW marked this pull request as ready for review October 16, 2024 01:50
@EdmondChuiHW EdmondChuiHW merged commit eb757e8 into facebookexperimental:main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntie huntie huntie approved these changes

@hoxyq hoxyq Awaiting requested review from hoxyq

@robhogan robhogan Awaiting requested review from robhogan

@vzaidman vzaidman Awaiting requested review from vzaidman

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdmondChuiHW @huntie @facebook-github-bot