Update disconnected dialog styling #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A first pass at cleaning up/consolidating the visual layout of this dialog following the UX changes in #116 (new options, which are preserved).
RemoteDebuggingTerminatedScreen
component with LitHtml and newer CSS module pattern.Note
Next, I'd love to add icons or some extra visual emphasis on each item. Unfortunately, there aren't great reusable components for this in the base revision of CDT. Can follow up on this in a future pass.
Test plan
Default
With FB-only feedback CTA
✅ All actions were re-tested
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.This commit could be upstreamed, with more future refinement.