Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Welcome docs links for launch #121

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

huntie
Copy link

@huntie huntie commented Oct 2, 2024

Summary

  • Substitute "React DevTools" guide for incoming "React Native DevTools" page (note: URL will be changed later via redirect).
  • Fix /docs/debugging-native-code link.
  • Fix Flex layout behaviour for link thumbnails.

Test plan

image
Before After
image image
flex-shrink: 0 fixes thumbnail alignment when resized.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

- Substitute "React DevTools" guide for incoming "React Native DevTools" page (note: URL will be changed later via redirect)
- Fix `/docs/debugging-native-code` link
@huntie huntie force-pushed the welcome-docs-links branch from 3fb6b65 to de79fc2 Compare October 2, 2024 15:44
@huntie huntie requested a review from vzaidman October 2, 2024 15:44
@huntie huntie merged commit 16dcac5 into facebookexperimental:main Oct 2, 2024
3 checks passed
@huntie huntie deleted the welcome-docs-links branch October 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants