Run npm run check-lint

[EdmondChuiHW]

Summary

Got ESLint going for VS Code. Lint errors start popping up:

To make ESLint work for this repo, Disable (Workspace) for Meta ESLint; Enable (Workspace) for public ESLint:

Test plan

npm run check-lint (will auto-fix)

Upstreaming plan

• This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
• This commit is React Native-specific and cannot be upstreamed.

[motiz88]

Looks like this will just be a merge conflict when we upgrade Chrome. Why does the linter think these can be removed?

[EdmondChuiHW]

They're unused so linter deletes them.

But just checked upstream and they have it there. I suppose Chrome team doesn't run these check commands then.

https://github.com/ChromeDevTools/devtools-frontend/blob/ac3e85ae479bf5c110a1261296ea5f515d9f2497/front_end/panels/js_profiler/js_profiler-meta.ts#L20-L27

I was thinking keeping linter happy would help us avoid merge conflicts in the future, but it's doing the opposite.

Commands from https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/README.md#useful-commands

(check-loc is also missing from package.json)

Will reach out to Chrome team and see if the above docs on formatting and lint checks are current.

Turning off linter in local editor for now.

Closing.