fix[react-devtools]: initialize bridge only after domain is ready #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bridge
andStore
should only be created after the domain initialization. This is becauseBridge
is attempting to send some messages to the other end right after it has been created. They should not be created in model's constructor, because at this point there is no guarantee that the binding (which is used for messaging) has already been installed.Test plan
Tested manually.
Before:
After:
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.