Add unit tests GitHub Action config #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdmondChuiHW
requested review from
motiz88,
huntie,
robhogan,
vzaidman and
hoxyq
vzaidman
requested changes
Aug 29, 2024
.github/workflows/build.yml
Outdated
| - name: Run unit tests | ||
| run: | | ||
| cd src | ||
| npm run unittest -- --expanded-reportin |
There was a problem hiding this comment.
expanded-reporting
G in the end is missing :)
There was a problem hiding this comment.
Both works for some reason lol. I guess Karma is resilient to typos haha
Added the g back.
EdmondChuiHW
force-pushed
the
unit-tests-gh-action
branch
from
3071c7b to
171ab0b
Compare
vzaidman
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add GitHub Action config to this repo for running unit tests automatically upon pushing.
The existing test failure was fixed via #104.
Test plan
This PR is the test 🤯
GitHub Action run result: https://github.com/facebookexperimental/rn-chrome-devtools-frontend/actions/runs/10616954789/job/29428603293?pr=109
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.