-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New home for reliability metrics #10
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright (c) Meta Platforms, Inc. and affiliates. | ||
// Copyright 2024 The Chromium Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import {type ReactNativeChromeDevToolsEvent} from './generated/type_defs/ReactNativeChromeDevToolsEventTypes.js'; | ||
|
||
type RNReliabilityMetrics = { | ||
sendEvent: (event: ReactNativeChromeDevToolsEvent) => void, | ||
}; | ||
|
||
export const RNReliabilityMetrics = ((): RNReliabilityMetrics => { | ||
function sendEvent(_event: ReactNativeChromeDevToolsEvent): void { | ||
} | ||
|
||
return { | ||
sendEvent, | ||
}; | ||
})(); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* Copyright 2024 The Chromium Authors. All rights reserved. | ||
* Use of this source code is governed by a BSD-style license that can be | ||
* found in the LICENSE file. | ||
* | ||
* @generated by WWW D54582949 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally this should be a signedsource comment rather than a diff reference. You can put a diff reference in a text file, or just in the commit message when updating any of these files' contents. This way there would be a clear source of truth for the latest WWW diff that touches these definitions. (Especially in the case of partial updates) |
||
*/ | ||
|
||
export type SetBreakpointEventEntryPoint = | ||
| "fileGutterClicked" | ||
| "savedStateRestored"; | ||
export type SetBreakpointEventType = | ||
| "logpoint" | ||
| "unconditionalBreakpoint" | ||
| "conditionalBreakpoint"; | ||
export type SetBreakpointRequestEvent = Readonly<{ | ||
event: "Debugger.SetBreakpoint.Request"; | ||
params: Readonly<{ | ||
entryPoint: SetBreakpointEventEntryPoint; | ||
requestID: string; | ||
type: SetBreakpointEventType; | ||
}>; | ||
}>; | ||
export type SetBreakpointResponseEvent = Readonly<{ | ||
event: "Debugger.SetBreakpoint.Response"; | ||
params: Readonly<{ breakpointID: string; requestID: string }>; | ||
}>; | ||
export type BreakpointResolvedEvent = Readonly<{ | ||
event: "Debugger.BreakpointResolved"; | ||
params: Readonly<{ breakpointID: string }>; | ||
}>; | ||
export type DebuggerPausedEvent = Readonly<{ | ||
event: "Debugger.Paused"; | ||
params: Readonly<{ breakpointID: null | undefined | string }>; | ||
}>; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* Copyright 2024 The Chromium Authors. All rights reserved. | ||
* Use of this source code is governed by a BSD-style license that can be | ||
* found in the LICENSE file. | ||
* | ||
* @generated by WWW D54582949 | ||
*/ | ||
|
||
import type { | ||
BreakpointResolvedEvent, | ||
DebuggerPausedEvent, | ||
SetBreakpointRequestEvent, | ||
SetBreakpointResponseEvent, | ||
} from "ReactNativeChromeDevToolsDebuggerEventTypes"; | ||
export type ReactNativeChromeDevToolsEvent = | ||
| SetBreakpointRequestEvent | ||
| SetBreakpointResponseEvent | ||
| BreakpointResolvedEvent | ||
| DebuggerPausedEvent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
?
Also, reusing the exact same name for a type and value seems problematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: How are we going to actually inject a
sendEvent
handler here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plan was for this to be a pub/sub API, so sending the actual events won't be here:
EdmondChuiHW@ecf72b6#diff-c62722ca9646ac9ec9e205faf447976c33eccbea2ce1a39791bf6f95d5041233R17
The closure style is my muscle memory for private variables + singleton; I will change it to a class + instance export instead as JS has real private fields now.
Will rework this PR to focus only on what are Reliability Metrics, how are safe defaults included, and the actual listener wiring (similar to facebook/react#22276)