Enable reloading DevTools when running in hosted mode #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In "hosted mode" (running DevTools as a web page in a browser), the
InspectorFrontendHost.reattach()method is a noop, which breaks the "Reload DevTools" action (useful e.g. after changing experiment settings). Here we update the stub implementation to directly call the provided callback, so that reloading works. Conceptually, this is just what DevTools used to do before ChromeDevTools@ab16a95.Upstreaming plan
This patch can probably be upstreamed to the DevTools repo as-is.
Test plan
reload.devtools.works.mov