Restore skip-stack-frames-pattern setting with empty default (#137)

facebookexperimental · Nov 25, 2024 · 6b80704 · 6b80704
1 parent 0030c54
commit 6b80704
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -6,6 +6,8 @@
 
 <!-- Explain how you've tested your change here -->
 
+- [ ] This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).
+
 # Upstreaming plan
 
 <!-- Pick one: -->

diff --git a/front_end/core/sdk/sdk-meta.ts b/front_end/core/sdk/sdk-meta.ts
@@ -327,6 +327,13 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
+  settingName: 'skip-stack-frames-pattern',
+  settingType: Common.Settings.SettingType.REGEX,
+  defaultValue: '',
+});
+
 Common.Settings.registerSettingExtension({
   storageType: Common.Settings.SettingStorageType.Synced,
   settingName: 'skip-content-scripts',