Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folly::IOBuf is missing tests #436

Open
JakeHillion opened this issue Dec 20, 2023 · 0 comments
Open

folly::IOBuf is missing tests #436

JakeHillion opened this issue Dec 20, 2023 · 0 comments
Labels
testing types Handling of a specific type

Comments

@JakeHillion
Copy link
Contributor

No description provided.

@JakeHillion JakeHillion added types Handling of a specific type testing labels Dec 20, 2023
@JakeHillion JakeHillion mentioned this issue Dec 20, 2023
Merged
JakeHillion added a commit to JakeHillion/object-introspection that referenced this issue Dec 20, 2023
@JakeHillion
tbv2: implement folly::IOBuf
e431c00 
folly::IOBuf does not have TreeBuilder v2 container support. Add it.

The implementation is a direct clone of v1. It still lacks tests.

Test Plan:
- It codegens on a prod type.
- No runtime testing... Bad form, I know.
- Issue created to add integration tests: facebookexperimental#436
JakeHillion added a commit that referenced this issue Dec 20, 2023
@JakeHillion
tbv2: implement folly::IOBuf
5a2ca8b 
folly::IOBuf does not have TreeBuilder v2 container support. Add it.

The implementation is a direct clone of v1. It still lacks tests.

Test Plan:
- It codegens on a prod type.
- No runtime testing... Bad form, I know.
- Issue created to add integration tests: #436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing types Handling of a specific type
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JakeHillion