-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker support #7
Conversation
@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…untime, provide docker-compose support
@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
docker/Dockerfile
Outdated
# docker run --rm -p 4433:4433 moqrelay | ||
# | ||
# Override logging level | ||
# docker run --rm -p 4433:4433 -e MOQ_LOG_LEVEL=INFO moqrelay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be helpful (for non-Meta folks) to include a description of how this project uses the available log levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks this is folly XLOG and the levels in use are: ERR, WARN, INFO, and DBG1-6 (for increasing levels of trace) . however I can't see the '--logging' flag having any effect. it is possible to set the following env vars and get richer output:
GLOG_minloglevel=0 GLOG_v=6 GLOG_logtostderr=1 ./_build/bin/moqrelayserver -port 4433 -cert ./certs/certificate.pem -key ./certs/certificate.key -endpoint "/moq"
@afrind am i seeing this right - suspect some logging init/flag processing code is needed?
@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
initial attempt at GitHub workflow to create a moxygen relay docker imange on pushes to main , PR's to main, and tagged version releases.
The docker image exposes port 4433 (changeable via env MOQ_PORT) and sets log level DBG (changeable via env MOQ_LOG_LEVEL)