Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #7

Closed
wants to merge 13 commits into from
Closed

Conversation

gmarzot
Copy link
Contributor

@gmarzot gmarzot commented Nov 12, 2024

initial attempt at GitHub workflow to create a moxygen relay docker imange on pushes to main , PR's to main, and tagged version releases.

The docker image exposes port 4433 (changeable via env MOQ_PORT) and sets log level DBG (changeable via env MOQ_LOG_LEVEL)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 12, 2024
@facebook-github-bot
Copy link
Contributor

@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

docker/Dockerfile Outdated Show resolved Hide resolved
# docker run --rm -p 4433:4433 moqrelay
#
# Override logging level
# docker run --rm -p 4433:4433 -e MOQ_LOG_LEVEL=INFO moqrelay

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be helpful (for non-Meta folks) to include a description of how this project uses the available log levels.

Copy link
Contributor Author

@gmarzot gmarzot Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks this is folly XLOG and the levels in use are: ERR, WARN, INFO, and DBG1-6 (for increasing levels of trace) . however I can't see the '--logging' flag having any effect. it is possible to set the following env vars and get richer output:

GLOG_minloglevel=0 GLOG_v=6 GLOG_logtostderr=1 ./_build/bin/moqrelayserver -port 4433 -cert ./certs/certificate.pem -key ./certs/certificate.key -endpoint "/moq"

@afrind am i seeing this right - suspect some logging init/flag processing code is needed?

@facebook-github-bot
Copy link
Contributor

@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@afrind merged this pull request in e6befe3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants