Use Consumer interface for MoQSession reads #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66881617 |
afrind
added a commit
to afrind/moxygen
that referenced
this pull request
Dec 19, 2024
Summary: This is the second half of the MoQSession rewrite. subscribe and fetch callers now supply a Consumer which the library drives as a callback. To make the consumer API work required changing the codec callbacks. The relay now connects a Forwarder (Consumer) to the upstream subscription directly. Differential Revision: D66881617
Summary: This is a major rewrite of MoQSession using the new Consumers interfaces. It's separated into the writes (this diff) and reads (next diff). Note the relay -- which does writes and reads -- is slightly broken in this diff but fixed in the next, so don't read too much into it. The previous "publish" API required the session to maintain a huge map of every currently open stream across the session and perform lookups into this map in order to do the writes. It also had a number API error cases that could be eliminated by constraining the interface. Now subscribeOK and fetchOK return a Consumer object which the publisher will use to pass track data according to those APIs. No maps are required -- the publisher hangs onto the handle(s) it needs to publish. MoQForwarder also had a major rewrite. It conveniently now implements the TrackConsumer interface as well, so a publisher can trivially publish to one or N subscribers. Differential Revision: D66881597
Summary: Pull Request resolved: facebookexperimental#13 This is the second half of the MoQSession rewrite. subscribe and fetch callers now supply a Consumer which the library drives as a callback. To make the consumer API work required changing the codec callbacks. The relay now connects a Forwarder (Consumer) to the upstream subscription directly. Differential Revision: D66881617
afrind
force-pushed
the
export-D66881617
branch
from
589c6ff to
3540108
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66881617 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the second half of the MoQSession rewrite. subscribe and fetch callers now supply a Consumer which the library drives as a callback.
To make the consumer API work required changing the codec callbacks.
The relay now connects a Forwarder (Consumer) to the upstream subscription directly.
Differential Revision: D66881617