Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang format all but the Win32-specific files #580

Merged
merged 157 commits into from
Oct 31, 2023
Merged

Clang format all but the Win32-specific files #580

merged 157 commits into from
Oct 31, 2023

Conversation

ispeters
Copy link
Contributor

This giant stack of changes is the result of running clang-format on everything but our Win32-specific files. For some reason, formatting win32/windows_thread_pool.hpp breaks the MSVC build. I'll tackle formatting those files in another PR.

This partly addresses #485. I haven't updated our .clang-format file, just applied the existing one. I figure it'll be a smaller, easier change to update the rules on a consistently-formatted repo, and having a consistently-formatted repo means I won't repeat the mistake of #579 where I accidentally included unrelated formatting changes in a behaviour-changing PR.

ispeters added 30 commits October 30, 2023 17:30
@ispeters
Format adapt_stream.hpp
2c271f4
@ispeters
Format allocate.hpp
d5250e9
@ispeters
Format any_object.hpp
6e35396
@ispeters
Format any_ref.hpp
cde78e4
@ispeters
Format any_scheduler.hpp
5b074bc
@ispeters
Format any_sender_of.hpp
efe7be7
@ispeters
Format any_unique.hpp
816cb41
@ispeters
Format async_manual_reset_event.hpp
c32f34d
@ispeters
Format async_mutext.hpp
47781ad
@ispeters
Format async_trace.hpp
25327bc
@ispeters
Format at_coroutine_exit.hpp
3a3d07a
@ispeters
Format await_transform.hpp
9558405
@ispeters
Format bind_back.hpp
67bafd8
@ispeters
Format blocking.hpp
ac9df63
@ispeters
Format bulk_join.hpp
1898f13
@ispeters
Format bulk_schedule.hpp
4386b66
@ispeters
Format bulk_transform.hpp
2f55797
@ispeters
Format connect_awaitable.hpp
6cbb7e2
@ispeters
Format continuations.hpp
356f94c
@ispeters
Format coroutine_concepts.hpp
11c7514
@ispeters
Format coroutine.hpp
5e9d237
@ispeters
Format create.hpp
56f3e54
@ispeters
Format defer.hpp
d26dcbe
@ispeters
Format delay.hpp
0590a87
@ispeters
Format dematerialize.hpp
88a59d6
@ispeters
Format detach_on_cancel.hpp
4b48816
@ispeters
Format done_as_optional.hpp
7668026
@ispeters
Format exception.hpp
f075e3a
@ispeters
Format execution_policy.hpp
e40ee52
@ispeters
Format file_concepts.hpp
56e981b
ispeters added 24 commits October 30, 2023 17:30
@ispeters
Format detail/with_type_erased_tag_invoke.hpp
7ec1b8e
@ispeters
Format linux/io_epoll_context.hpp
f07e894
@ispeters
Format linux/io_uring_context.hpp
e9d00f4
@ispeters
Format linux/mmap_region.hpp
59831df
@ispeters
Format linux/monotonic_clock.hpp
0f0e31f
@ispeters
Format linux/safe_file_descriptor.hpp
b0729d0
@ispeters
Format v0/async_scope.hpp
9f909a8
@ispeters
Format v1/async_scope.hpp
3fbd680
@ispeters
Format async_manual_reset_event.cpp
312b583
@ispeters
Format async_mutex.cpp
d0faea7
@ispeters
Format exception.cpp
b0d282d
@ispeters
Format inplace_stop_token.cpp
68e070c
@ispeters
Format manual_event_loop.cpp
ff780b9
@ispeters
Format static_thread_pool.cpp
2badc7b
@ispeters
Format task.cpp
4b3d7e9
@ispeters
Format thread_unsage_event_loop.cpp
00ba2bc
@ispeters
Format timed_single_thread_context.cpp
f945610
@ispeters
Format trampoline_scheduler.cpp
4bd8779
@ispeters
Format linux/io_epoll_context.cpp
97b5e99
@ispeters
Format linux/io_uring_context.cpp
4325b74
@ispeters
Format linux/mmap_region.cpp
383b5fc
@ispeters
Format linux/monotonic_clock.cpp
75f6386
@ispeters
Format linux/safe_file_descriptor.cpp
8340c57
@ispeters
Format linux/io_uring_syscall.hpp
16f1748
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2023
@ispeters ispeters requested a review from janondrusek October 31, 2023 00:59
janondrusek
janondrusek approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@janondrusek janondrusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge!

@ispeters ispeters merged commit a7a1f20 into main Oct 31, 2023
93 checks passed
@ispeters ispeters deleted the clang_format branch October 31, 2023 18:23
@ispeters ispeters mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janondrusek janondrusek janondrusek approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ispeters @janondrusek @facebook-github-bot