Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gcc-11...gcc-13 #573

Merged
merged 2 commits into from
Oct 20, 2023
Merged

add gcc-11...gcc-13 #573

merged 2 commits into from
Oct 20, 2023

Conversation

janondrusek
Copy link
Contributor

@janondrusek janondrusek commented Oct 20, 2023 •
edited
Loading

  • tweak noexcept constructors in tests due to a regression in GCC 11+
  • tweak test build failures
  • enable CI steps
  • bump GTest to 1.14

@janondrusek janondrusek requested a review from ispeters October 20, 2023 20:28
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2023
@janondrusek janondrusek force-pushed the ci branch 2 times, most recently from 9eed42e to d1d1a47 Compare October 20, 2023 21:29
@ispeters @janondrusek
Fix dangling temporary warning in gcc 13
7721fa1 
This diff inlines calls to `extract_this` to convince GCC 13 that there
are no dangling temporaries.
@janondrusek
add gcc-11...gcc-13
cf06db8 
* tweak noexcept constructors in tests due to a regression in GCC 11+
* tweak test build failures
* enable CI steps
* bump GTest to 1.14
@janondrusek janondrusek changed the title add gcc-11...gcc-12 add gcc-11...gcc-13 Oct 20, 2023
ispeters
ispeters approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as all the CI is green.

@ispeters ispeters mentioned this pull request Oct 20, 2023
Closed
@janondrusek janondrusek linked an issue Oct 20, 2023 that may be closed by this pull request
build libunifex failed with g++ 13.1.0 #569
Closed
@janondrusek janondrusek merged commit 7d5d64a into facebookexperimental:main Oct 20, 2023
63 checks passed
@janondrusek janondrusek deleted the ci branch October 20, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ispeters ispeters ispeters approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build libunifex failed with g++ 13.1.0
3 participants
@janondrusek @ispeters @facebook-github-bot