Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add io_uring_context::open_listening_socket #531

Merged
merged 1 commit into from
May 26, 2023

Conversation

janondrusek
Copy link
Contributor

  • opens a socket on a specified port
  • exposes a Stream of async_read_write_file to handle accept(s)

@janondrusek janondrusek requested a review from ispeters May 25, 2023 20:24
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2023
@janondrusek janondrusek force-pushed the accept-stream branch 9 times, most recently from 8bc0ccb to d2465e9 Compare May 25, 2023 22:38
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I've left a whole bunch of comments.

include/unifex/linux/io_uring_context.hpp Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Outdated Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Outdated Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Outdated Show resolved Hide resolved
include/unifex/socket_concepts.hpp Show resolved Hide resolved
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I've left a whole bunch of comments.

* opens a socket on a specified port
* exposes a _Stream_ of `async_read_write_file` to handle accept(s)
@janondrusek janondrusek merged commit a4a53ca into facebookexperimental:main May 26, 2023
@janondrusek janondrusek deleted the accept-stream branch May 26, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants