Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement scheduler affinity #527

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Reimplement scheduler affinity #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4097620
Reimplement Scheduler affinity
ispeters May 24, 2023
e002af2
Clean up self-review comments
ispeters May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/unifex/at_coroutine_exit.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ namespace _at_coroutine_exit {
} at_coroutine_exit{};
} // namespace _at_coroutine_exit

// TODO: verify that `at_coroutine_exit()` can't be used to break scheduler
// affinity by running an async task that reschedules
Comment on lines +321 to +322
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at_coroutine_exit can already break Scheduler affinity so this is a TODO, which I've captured in #535.

using _at_coroutine_exit::at_coroutine_exit;

} // namespace unifex
Expand Down
Loading