Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sudoku example #340

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Sudoku example #340

wants to merge 7 commits into from

Conversation

kirkshoop
Copy link
Contributor

ported the sudoku example from TBB examples/thread_group/sudoku

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2021
@ericniebler
Copy link
Collaborator

Do we really want to merge my change to get_scheduler to make it possibly noexcept(false)? Lewis' feedback is that that is going to be problematic, and I haven't had a chance to go back and do different.

@kirkshoop kirkshoop force-pushed the sudoku branch 2 times, most recently from 5786f2a to b3c1809 Compare September 2, 2021 20:16
AnujYamdagni
AnujYamdagni suggested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@AnujYamdagni AnujYamdagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're doing repo cleanup - this seems stale. Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnujYamdagni AnujYamdagni AnujYamdagni requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirkshoop @ericniebler @AnujYamdagni @facebook-github-bot